• Clicking here or scanning the QR code below to access App Center
• Then installing the build number pr19776-f2a8f24 on your iPhone

• Clicking here or scanning the QR code below to access App Center
• Then installing the build number pr19776-f2a8f24 on your iPhone

@sla8c , I looked at this change and I agree with you that it makes perfect sense.

I also tried to understand why it might not be working. I found that PeriodOperation (StatsPeriodAsyncOperation) is not marked as finished, therefore the queue never triggers barrierBlock. I'm not sure why we're not marking the operation as finished after we receive the data.

This is a quick change that I made to StatsPeriodAsyncOperation:

    override func main() {
        service?.getData(for: period, endingOn: date, limit: limit) { [unowned self] (type: TimeStatsType?, error: Error?) in
            if self.isCancelled {
                self.state = .isFinished
                return
            }

            self.completion(type, error)
            self. State = .isFinished // <- code of line that was added
        }
    }

After this change, the block is triggered:

@staskus as discussed I've pushed a change for this using DispatchGroups and its ready for review. Thanks! 🙇

@guarani let me know if you'd like to review as well.

👋 @staskus, sure – I'd like to review this now.

I'll wait for your take. We can make any improvements if needed ourselves.

Ok, sounds like a plan 👍

• Is saving to core data only needed when the feature flag is on (and not when it's off)?

If we don't add Feature Flags, we would make this functionality available for the non-revamped version of Stats as well. I tested and I don't see a problem with that, outside the fact that this improvement then could get shipped before the actual revamped stats.

• Is saving to core data even when there's an error fetching the data the right choice?

No issues happen because of that but there's a bit of inefficiency.

If an error happens for all the calls, then there's no change in data in the state, and the same information gets persisted again.

If an error happens for one or two of the calls and the others succeed then we're correct to persist data.

Merging with one approval. Since the functionality is left under the feature flag it's safe to merge.